Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make discretization backend agnostic #896

Merged
merged 21 commits into from
Sep 20, 2023

Conversation

divyashreepathihalli
Copy link
Collaborator

No description provided.

@divyashreepathihalli divyashreepathihalli marked this pull request as draft September 15, 2023 22:37
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch coverage: 80.76% and project coverage change: -12.93% ⚠️

Comparison is base (1704ecf) 79.75% compared to head (fa12ff5) 66.83%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #896       +/-   ##
===========================================
- Coverage   79.75%   66.83%   -12.93%     
===========================================
  Files         318      318               
  Lines       28638    28653       +15     
  Branches     5451     5456        +5     
===========================================
- Hits        22841    19149     -3692     
- Misses       4333     8163     +3830     
+ Partials     1464     1341      -123     
Flag Coverage Δ
keras_core 66.83% <80.76%> (-12.86%) ⬇️
keras_core-numpy ?
keras_core-tensorflow 66.83% <80.76%> (+<0.01%) ⬆️
keras_core-torch ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
keras_core/backend/common/backend_utils.py 65.71% <73.68%> (-34.29%) ⬇️
keras_core/layers/preprocessing/discretization.py 81.48% <100.00%> (-1.56%) ⬇️

... and 75 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Some initial comments.

keras_core/layers/preprocessing/discretization.py Outdated Show resolved Hide resolved
keras_core/layers/preprocessing/discretization.py Outdated Show resolved Hide resolved
keras_core/layers/preprocessing/discretization.py Outdated Show resolved Hide resolved
keras_core/layers/preprocessing/discretization.py Outdated Show resolved Hide resolved
keras_core/layers/preprocessing/discretization.py Outdated Show resolved Hide resolved
@fchollet fchollet merged commit fa12ff5 into keras-team:main Sep 20, 2023
4 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants